This repository was archived by the owner on Feb 14, 2022. It is now read-only.
use axios for sync without callback#7
Merged
shiftpsh merged 7 commits intosolved-ac:masterfrom Jul 28, 2019
mu-hun:async-without-callback
Merged
use axios for sync without callback#7shiftpsh merged 7 commits intosolved-ac:masterfrom mu-hun:async-without-callback
shiftpsh merged 7 commits intosolved-ac:masterfrom
mu-hun:async-without-callback
Conversation
Merged
Contributor
Author
shiftpsh
suggested changes
Jul 28, 2019
Member
shiftpsh
left a comment
shiftpsh
left a comment
There was a problem hiding this comment.
좋네요. 파일명에 버전을 적어 주시면 감사하겠습니다. bootstrap.3.2.0.min.js 처럼요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
콜백 구문의 복잡도를 줄이기 위해 axios 를 사용하면 어떨까 싶어 draft PR을 보내드립니다.
Promise 기반의 HTTP 클라이언트 axios를 사용하면 DRY(Don't-Repeat-Yourself)한 코드를 쉽게 유지할 수 있습니다.
./content.js의 경우 (#5 와 마찬가지로) 수정을 하지 않았습니다.