Conversation
Jacsep
approved these changes
Aug 24, 2021
nullfrit
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
The issue of strange behaviour of not being able to upload small file after a large file using the python sdk has been addressed with this fix.
Tested four scenarios, where small files are uploaded using upload_file and large files using upload_file_by_chunks.
- uploaded large -> large files (pass)
- uploaded large -> small files (pass)
- uploaded small -> large files (pass)
- uploaded small -> small files (pass)
Extra observations
upload_file_by_chunks() was tested having chunk size assigned from values between 10kb to 100mb (also tested 1gb chunk size) on uploading a 100mb file.
- Error message
Error splitting and uploading file with file_id ## and chunkId 1
Request experienced an internal error, please contact your system administrator referencing support id.
Occurred when chunk size was set from 30mb upwards.
Chunk sizes between 10-25mb appear to work without issue.
Setting chunk sizes too small relative to the original file size (i.e. 10kb) reduces upload speed performance, increasing upload times and likelihood of upload failure.
myfoxtail
approved these changes
Aug 25, 2021
myfoxtail
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original dictionary is updated if copy() method is not used to copy access_token dictionary