Skip to content

Conversation

@meln1k
Copy link
Member

@meln1k meln1k commented Jun 24, 2022

Description

Fixed a bug where the existing edges were not overwritten, and therefore deleted during the collection

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox
  • Document new or updated functionality (someengineering/resoto.com#XXXX)

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Co-authored-by: Matthias Veit <aquamatthias@users.noreply.github.com>
aquamatthias
aquamatthias previously approved these changes Jun 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #956 (a03eb53) into main (2666acc) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   90.21%   90.19%   -0.02%     
==========================================
  Files          68       68              
  Lines       10202    10203       +1     
==========================================
- Hits         9204     9203       -1     
- Misses        998     1000       +2     
Flag Coverage Δ
resotocore 90.19% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
resotocore/resotocore/db/graphdb.py 93.13% <50.00%> (-0.26%) ⬇️
...tocore/action_handlers/merge_outer_edge_handler.py 88.88% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2666acc...a03eb53. Read the comment docs.

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@aquamatthias aquamatthias merged commit 4fa57f0 into main Jun 24, 2022
@aquamatthias aquamatthias deleted the nm/fix-outer-edge-imports branch June 24, 2022 10:35
aquamatthias added a commit that referenced this pull request Jun 24, 2022
* [resotocore][fix] Fix outer edge merge handler

* move the update back

* small cleanup

* Update resotocore/resotocore/db/graphdb.py

Co-authored-by: Matthias Veit <aquamatthias@users.noreply.github.com>

* another test

* add some notes for the test

Co-authored-by: Matthias Veit <aquamatthias@users.noreply.github.com>
(cherry picked from commit 4fa57f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants