Dev #64
Merged
Dev #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to the Entry model to make the chart work in other languages. nsDateFormatter.locale = NSLocale(localeIdentifier: "EN")
make sure the date formatter is set to english
Call Handler when failure occurs, update threading strategy
# Conflicts: # Nightscouter/SiteListTableViewController.swift # Shared Framework Code/API/NightscoutAppDataManager.swift
Deigning a protocol for what a alarm manager might need to do. Also, stopped downloading audio from web to play, grabbing file directly from the file system.
…anner when alarm is sounding.
Added banner to detail view
Given the complexity (har) of the issue we decided to punt this feature for now. The size of the data and the limitations of the platform require a larger strategy.
These changes to @rodericj code will abandon the by payload transfer in favor of a smaller amount of data transfer. I also added back complication creation on the watch, but the Network code needs to be rewritten to be more efficient on the watch so that the data can update efficiently.
…everything is broken.
- Add BuddyBuildSDK.framework - Initialize in App Delegate
Encode the nextRefreshDate to UserDefaults
A few easy wins to simplify and make more readable
the networking code:
- Remove the NightsscouterBaseOperation as it
doesn’t provide any more information than
the NightscouterOperation protocol
- Simplify our use of optionals. In many cases
we know that we will get what we are asking
for. In cases where we didn't know, perfer
a guard and no action rather than the `?` and `!` dance.
- Remove pebble and cal from the `APIRoutes`
as they were never called. Doing this
allowed us to simplify the switch on
the endpoint. All of the options do
nearly the same thing
- Remove `userInitiated` for network
requests as it was never used
and shouldn't really matter
- file private -> private in NightScout.swift
Simplify the networking code
Still need to investigate why defaults.sync was not setting true.
This reverts commit 0d68964.
Wip xcode 8.1
don’t use tableFooterView use tableHeaderView instead
Wrong table view was being used.
watchos background updates working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS App 1.3.1 - Ready for Sale
Thank you @rodericj for you help in this release.