Skip to content

Fix builds#787

Merged
core23 merged 2 commits intosonata-project:4.xfrom
jordisala1991:hotfix/build
Dec 4, 2021
Merged

Fix builds#787
core23 merged 2 commits intosonata-project:4.xfrom
jordisala1991:hotfix/build

Conversation

@jordisala1991
Copy link
Copy Markdown
Member

@jordisala1991 jordisala1991 commented Dec 4, 2021

Subject

I am targeting this branch, because this is BC.

Changelog

### Removed
- Symfony deprecations

@jordisala1991 jordisala1991 force-pushed the hotfix/build branch 2 times, most recently from c65444f to 73bb187 Compare December 4, 2021 18:52
Comment thread tests/Controller/CategoryAdminControllerTest.php Outdated
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
@jordisala1991 jordisala1991 requested review from a team and VincentLanglet December 4, 2021 19:01
@core23 core23 merged commit d99795f into sonata-project:4.x Dec 4, 2021
@VincentLanglet
Copy link
Copy Markdown
Member

I just tried to do the same in SonataMedia and discovered some admin was using POST request
https://github.com/sonata-project/SonataMediaBundle/blob/4.x/src/Admin/BaseMediaAdmin.php#L130

Are you sure about the query->get thing @core23 @jordisala1991 ?

@core23 core23 added patch and removed pedantic labels Dec 4, 2021
@jordisala1991
Copy link
Copy Markdown
Member Author

I just tried to do the same in SonataMedia and discovered some admin was using POST request

https://github.com/sonata-project/SonataMediaBundle/blob/4.x/src/Admin/BaseMediaAdmin.php#L130

Are you sure about the query->get thing @core23 @jordisala1991 ?

Not 100% sure tbh. About that post thing, it is used to know when the form is submitted AFAIK

@jordisala1991 jordisala1991 deleted the hotfix/build branch December 4, 2021 19:29
@VincentLanglet
Copy link
Copy Markdown
Member

I just tried to do the same in SonataMedia and discovered some admin was using POST request
https://github.com/sonata-project/SonataMediaBundle/blob/4.x/src/Admin/BaseMediaAdmin.php#L130
Are you sure about the query->get thing @core23 @jordisala1991 ?

Not 100% sure tbh. About that post thing, it is used to know when the form is submitted AFAIK

I'm not familiar enough with the request, but when POST request are made, persistent parameters are in the $request->request instead of $request->query no ? Doesn't it means we're loosing all the persistent parameters when doing a post request then with this PR ?

@VincentLanglet
Copy link
Copy Markdown
Member

I don't use this bundle. @core23 I think you're using it ; I would recommend to try those changes before doing another release.

@core23
Copy link
Copy Markdown
Member

core23 commented Dec 4, 2021

I don't use this bundle. @core23 I think you're using it ; I would recommend to try those changes before doing another release.

👍 I'll check this before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants