Backport changes from AdminBundle to CategoryAdminController#820
Merged
jordisala1991 merged 1 commit intosonata-project:4.xfrom Feb 10, 2022
Merged
Backport changes from AdminBundle to CategoryAdminController#820jordisala1991 merged 1 commit intosonata-project:4.xfrom
jordisala1991 merged 1 commit intosonata-project:4.xfrom
Conversation
Member
VincentLanglet
left a comment
VincentLanglet
left a comment
There was a problem hiding this comment.
Can we add a functional test to detect this bug ?
Asserting a 200 on the page should be enough in https://github.com/sonata-project/SonataClassificationBundle/blob/4.x/tests/App/Action/CartegoryAdminTest.php#L24 ?
And we could rename the file CategoryAdminTest instead of cartegory
core23
force-pushed
the
fix-controller
branch
3 times, most recently
from
1ac7b0a to
efee722
Compare
VincentLanglet
approved these changes
Feb 8, 2022
VincentLanglet
requested changes
Feb 8, 2022
Member
VincentLanglet
left a comment
VincentLanglet
left a comment
There was a problem hiding this comment.
Seems like there is something wrong in the filter of the list url
core23
force-pushed
the
fix-controller
branch
from
efee722 to
09881c8
Compare
Member
Author
Fixed |
VincentLanglet
approved these changes
Feb 8, 2022
Member
|
If you can review @jordisala1991 I'll merge this and create a patch release. |
jordisala1991
approved these changes
Feb 10, 2022
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
There was a template error, because the
export_formatsvariable does not exist.I am targeting this branch, because this is a bugfix.
Changelog