Skip to content

Conversation

@core23
Copy link
Member

@core23 core23 commented Dec 4, 2017

I am targeting this branch, because this is a bugfix.

Changelog

### Changed
 - Changed default title to `Project name`

Subject

There's no reason for Sonata Project as the default SEO title.

@core23 core23 added the patch label Dec 4, 2017
->end()
->scalarNode('separator')->defaultValue(' - ')->end()
->scalarNode('title')->defaultValue('Sonata Project')->end()
->scalarNode('title')->defaultValue('')->end()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then we should remove the ->defaultValue(''), too

Copy link
Contributor

@greg0ire greg0ire Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing it to "Change me, you moron!"?

@soullivaneuh
Copy link
Member

Not a big fan. What is the issue with the default value? Having this appearing tells the user to change it.

@core23 core23 force-pushed the patch/default-seo branch from 19ab974 to 73894a6 Compare December 6, 2017 15:55
@core23
Copy link
Member Author

core23 commented Dec 6, 2017

If we have a default title, it should have a useful value. Sonata project isn't useful for the most websites.

->end()
->scalarNode('separator')->defaultValue(' - ')->end()
->scalarNode('title')->defaultValue('Sonata Project')->end()
->scalarNode('title')->end()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannotBeEmpty? Also, shouldn't some markup be removed from the page?
If we are going this route and not putting some Lorem Ipsum everywhere, I think the logo should be removed too, right?

@OskarStark
Copy link
Member

If we have a default title, it should have a useful value. Sonata project isn't useful for the most websites.

Switching it to "Project Name"

@greg0ire
Copy link
Contributor

greg0ire commented Dec 7, 2017

People would indeed be more likely to change it if you name it that way

@core23
Copy link
Member Author

core23 commented Dec 10, 2017

What about Homepage as the default page title?

@greg0ire
Copy link
Contributor

@core23 this shows up on every page, right? I really prefer @OskarStark 's proposal. That's something people should customize if they have many backends that use sonata. They could even customize it for other envs like staging

@jordisala1991
Copy link
Member

I also prefer @OskarStark proposal

OskarStark
OskarStark previously approved these changes Dec 11, 2017
@greg0ire greg0ire merged commit b44276f into sonata-project:2.x Dec 12, 2017
@greg0ire
Copy link
Contributor

Thanks @core23 !

@core23 core23 deleted the patch/default-seo branch December 12, 2017 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants