-
-
Notifications
You must be signed in to change notification settings - Fork 89
Removed default title #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ->end() | ||
| ->scalarNode('separator')->defaultValue(' - ')->end() | ||
| ->scalarNode('title')->defaultValue('Sonata Project')->end() | ||
| ->scalarNode('title')->defaultValue('')->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then we should remove the ->defaultValue(''), too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about changing it to "Change me, you moron!"?
|
Not a big fan. What is the issue with the default value? Having this appearing tells the user to change it. |
19ab974 to
73894a6
Compare
|
If we have a default title, it should have a useful value. Sonata project isn't useful for the most websites. |
| ->end() | ||
| ->scalarNode('separator')->defaultValue(' - ')->end() | ||
| ->scalarNode('title')->defaultValue('Sonata Project')->end() | ||
| ->scalarNode('title')->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cannotBeEmpty? Also, shouldn't some markup be removed from the page?
If we are going this route and not putting some Lorem Ipsum everywhere, I think the logo should be removed too, right?
Switching it to "Project Name" |
|
People would indeed be more likely to change it if you name it that way |
73894a6 to
d027f60
Compare
|
What about |
|
@core23 this shows up on every page, right? I really prefer @OskarStark 's proposal. That's something people should customize if they have many backends that use sonata. They could even customize it for other envs like staging |
|
I also prefer @OskarStark proposal |
d027f60 to
51285af
Compare
51285af to
2d328ef
Compare
|
Thanks @core23 ! |
I am targeting this branch, because this is a bugfix.
Changelog
Subject
There's no reason for
Sonata Projectas the default SEO title.