This repository was archived by the owner on Jul 22, 2022. It is now read-only.
Bump sonata-project/datagrid-bundle to version ^3.0 #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
suggested changes
Sep 25, 2020
wbloszyk
force-pushed
the
bump_datagrid
branch
from
0814a7d to
c5715e1
Compare
8 tasks
Collaborator
|
Could you please rebase your PR and fix merge conflicts? |
wbloszyk
force-pushed
the
bump_datagrid
branch
from
c5715e1 to
adc0bb3
Compare
VincentLanglet
approved these changes
Feb 1, 2021
OskarStark
approved these changes
Feb 1, 2021
OskarStark
reviewed
Feb 1, 2021
| "sonata-project/seo-bundle": "^2.4", | ||
| "sonata-project/twig-extensions": "^0.1 || ^1.2", | ||
| "sonata-project/user-bundle": "^4.0", | ||
| "sonata-project/user-bundle": "^4.9", |
Member
Author
There was a problem hiding this comment.
Yes, user-bundle < 4.9 require datagrid 2.x.
Member
Author
|
@OskarStark Can we merge it? |
OskarStark
approved these changes
Feb 2, 2021
Member
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because we should bump in this branch. It is potential BC-break.
Changelog
To do
sonata-project/user-bundlecomposer.jsonknplabs/knp-menu-bundleto ^3.0 - Bump knplabs/knp-menu-bundle #769