feat(lsp): implement real-time diagnostics and decouple core#59
Merged
Conversation
This PR implements real-time diagnostics updates for the LSP server and refactors the core module. - Implement in-memory document synchronization in LSP backend - Fix stale diagnostics by ensuring all workspace files receive diagnostic updates - Decouple `core` module from `tower_lsp` by using `HashMap<PathBuf, String>` for overrides - Implement path normalization (canonicalization) for reliable document lookup - Update CLI handlers to match new `collect_workspace_all` signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements real-time diagnostics updates for the LSP server and refactors the core module to remove dependencies on LSP types.
Changes
check_workspaceandcollect_workspace_allto acceptHashMap<PathBuf, String>for overrides, decouplingcorefromtower_lspanddashmap.Nonefor the newoverridesargument incollect_workspace_all.Verification
cargo check,cargo build,cargo fmt, andcargo clippypass.