fix: use suffix matching for MCP tool names in assertions#21
Merged
Conversation
`check_db_query` used `row.get::<_, String>(0)` which fails for INTEGER columns like COUNT(*). Use `rusqlite::types::Value` to handle Integer, Real, Text, Blob, and Null variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MCP tools use fully qualified names (e.g. mcp__plugin_...__search_patents) but check_tool_use and check_param used exact equality. This caused all tool-use and tool-param assertions to fail for MCP tools. Change all 4 comparisons from == to ends_with, consistent with check_mcp_success. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_tool_useandcheck_paramto match tool names usingends_withinstead of exact equalitymcp__plugin_google-patent-cli_google-patent-cli__search_patents), so exact match always failedcheck_mcp_successwhich already usedends_withTest plan
mise run skill-teston google-patent-cli: all 11 tests pass (was failing before)cargo testpasses🤖 Generated with Claude Code