Skip to content

SAI apigen support for tables with no action parameters and a single action #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022
Merged

SAI apigen support for tables with no action parameters and a single action #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dash-pipeline/SAI/templates/saiapi.h.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*/

{% for table in sai_api.tables %}
{% if table.actions | length > 1 %}
{% if table.actions | length > 1 or ((table.actions | length == 1) and (((table.is_object == 'false') or (table['keys'] | length <= 1)) and ((table['actionParams'] | length == 0)))) %}
/**
* @brief Attribute data for #SAI_{{ table.name | upper }}_ATTR_ACTION
*/
Expand Down Expand Up @@ -113,7 +113,7 @@ typedef enum _sai_{{ table.name }}_attr_t
SAI_{{ table.name | upper }}_ATTR_START,

{% set ns = namespace(firstattr=false) %}
{% if table.actions | length > 1 %}
{% if table.actions | length > 1 or ((table.actions | length == 1) and (((table.is_object == 'false') or (table['keys'] | length <= 1)) and ((table['actionParams'] | length == 0)))) %}
/**
* @brief Action
*
Expand Down
4 changes: 2 additions & 2 deletions dash-pipeline/bmv2/dash_pipeline.p4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ control dash_ingress(inout headers_t hdr,

actions = {
accept;
deny;
@defaultonly deny;
}

const default_action = deny;
Expand Down Expand Up @@ -175,7 +175,7 @@ control dash_ingress(inout headers_t hdr,

actions = {
permit;
deny;
@defaultonly deny;
}

const default_action = deny;
Expand Down