[patch] add patch "net: sch_generic: fix the missing new qdisc assign…#213
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom May 31, 2021
Merged
Conversation
…ment bug" To fix ENOBUFS returned by send() instead of ENETDOWN when interface flaps. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Collaborator
|
@stepanblyschak is there a github issue which this fix refers to? if not, can you update the PR description of what was observed so this fix solves it? |
liat-grozovik
approved these changes
May 25, 2021
Collaborator
|
Once approved, can you please add label for 202012? I don't have the permission to do so. |
qiluo-msft
approved these changes
May 25, 2021
Collaborator
|
@qiluo-msft can you please merge and cherry pick to 202012? |
Collaborator
|
@qiluo-msft - Thanks for approving this PR. Can you please add the label - required for 202012 ? Thanks! |
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 1, 2021
…ment bug" (#213) To fix ENOBUFS returned by send() instead of ENETDOWN when interface flaps. The original issue is - when performing LAG memeber flapping, a LAG memeber can stuck in disabled state until next interface flap. This is because, teamd calls lacp_send() when setting internal LAG member state which ignores ENETDOWN but not ENOBUFS. This will lead to a situation when internal LACP member state stucks in disabled state.
dal00
pushed a commit
to kamelnetworks/sonic-linux-kernel
that referenced
this pull request
Jul 20, 2025
…ure (sonic-net#213) - The last del command in the following flow will fail because of a bug in MgmtIfaceCfg. During vrf add, it tries to update the default route and if the route is not present, the command will write an error log - MgmtIfaceCfg is not saving the saving the state in the internal variable. This will cause problem next time and update comes. ``` config vrf add mgmt config vrf del mgmt config vrf add mgmt config vrf del mgmt ``` - Added a UT and verified the fix ``` Dec 18 03:57:43 sonic hostcfgd[98362]: MgmtIfaceCfg: mgmt vrf state update Dec 18 03:57:43 sonic hostcfgd[98362]: Set mgmt vrf state true Dec 18 03:57:50 sonic hostcfgd[98362]: MgmtIfaceCfg: Could not delete eth0 route Dec 18 03:58:05 sonic hostcfgd[98362]: MgmtIfaceCfg: mgmt vrf state update Dec 18 03:58:05 sonic hostcfgd[98362]: Set mgmt vrf state false ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ment bug"
To fix ENOBUFS returned by send() instead of ENETDOWN when interface
flaps.
The original issue is - when performing LAG memeber flapping, a LAG memeber can stuck in disabled state until next interface flap. This is because, teamd calls lacp_send() when setting internal LAG member state which ignores ENETDOWN but not ENOBUFS. This will lead to a situation when internal LACP member state stucks in disabled state.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com