Skip to content

Update to Linux 5.10.179#328

Merged
saiarcot895 merged 9 commits intosonic-net:masterfrom
saiarcot895:linux-5.10.179-update
Sep 13, 2023
Merged

Update to Linux 5.10.179#328
saiarcot895 merged 9 commits intosonic-net:masterfrom
saiarcot895:linux-5.10.179-update

Conversation

@saiarcot895
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 commented Sep 4, 2023

Update from 5.10.140 to 5.10.179 (published as linux 5.10.179-3 by Debian). This brings in a number of bug and security fixes.

Update our ABI version number to 23-2 to match the ABI version 23 used by Debian for 5.10.179.

One patch needed some changes; all other patches are unchanged.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@saiarcot895 saiarcot895 requested a review from a team as a code owner September 4, 2023 16:42
Copy link
Copy Markdown
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this update.

It’d be great if you mentioned the devices you tested this on.

I wouldn’t put a dot/period at the end of commit messages summaries.

Comment thread Makefile
KVERSION_SHORT ?= 5.10.0-23-$(KERNEL_ABI_MINOR_VERSION)
KVERSION ?= $(KVERSION_SHORT)-amd64
KERNEL_VERSION ?= 5.10.179
KERNEL_SUBVERSION ?= 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the subversion, and why change it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subversion refers to the Debian version number. In this case, version 5.10.179-3 from Debian is being used.

-abiname: 18
+abiname: 18-2
-abiname: 23
+abiname: 23-2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be great if you elaborated in the commit message, why 23.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABI 23 is the ABI version number that Debian is using. This typically gets incremented by one for each minor kernel update that Debian does (i.e. going from 5.10.179 to the current 5.10.191).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Please reference the Debian package you base your change on. For example I found different versions: version 5.10.179+3~deb10u1 and 5.10.179+5~deb10u1, where the change-log of the latter contains:

Changes:
linux-signed-5.10-arm64 (5.10.179+5~deb10u1) buster-security; urgency=high
.

  • Sign kernel from linux-5.10 5.10.179-5~deb10u1
    .
  • Rebuild for buster:
    • Change ABI number to 0.deb10.24

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the versions you found are for Buster (hinted by the ~deb10u1 at the end, which is used for backports).

I've updated the main PR description to include the version number and a link to the publishing of that version.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@saiarcot895
Copy link
Copy Markdown
Contributor Author

FYI @keboliu @vivekrnv, several Mellanox patches have been disabled since they are present in 5.10.179.

Copy link
Copy Markdown
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to address the nits I mentioned, but all in all, it looks great. Thank you for updating the description.

@saiarcot895 saiarcot895 merged commit 3158031 into sonic-net:master Sep 13, 2023
@saiarcot895 saiarcot895 deleted the linux-5.10.179-update branch September 13, 2023 23:04
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Sep 20, 2023
## How I did it

Depends on sonic-net/sonic-linux-kernel#328 and sonic-net/saibcm-modules#12.

#### How to verify it

Verified that the image boots up, BGP comes up, and a basic warm-reboot works on VS, broadcom, and mellanox.
@saiarcot895
Copy link
Copy Markdown
Contributor Author

Backport ADO: part of 24592132

StormLiangMS pushed a commit that referenced this pull request Oct 7, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Fix kversion

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Update to 5.10.179-3.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Disable 6 Mellanox patches as those changes are already included

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Remove Mellanox patches that are not required for 5.10.179

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
@StormLiangMS
Copy link
Copy Markdown
Contributor

StormLiangMS commented Oct 8, 2023

StormLiangMS added a commit that referenced this pull request Oct 8, 2023
@saiarcot895
Copy link
Copy Markdown
Contributor Author

Hi @StormLiangMS, for backporting, there would need to be additional separate changes on the sonic-buildimage repo side. I'll create manual PRs for both.

saiarcot895 added a commit to saiarcot895/sonic-linux-kernel that referenced this pull request Oct 12, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Fix kversion

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Update to 5.10.179-3.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Disable 6 Mellanox patches as those changes are already included

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Remove Mellanox patches that are not required for 5.10.179

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
StormLiangMS pushed a commit that referenced this pull request Oct 17, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.



* Fix kversion



* Update to 5.10.179-3.



* Disable 6 Mellanox patches as those changes are already included



* Remove Mellanox patches that are not required for 5.10.179

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
saiarcot895 added a commit to saiarcot895/sonic-linux-kernel that referenced this pull request Nov 2, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Fix kversion

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Update to 5.10.179-3.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Disable 6 Mellanox patches as those changes are already included

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Remove Mellanox patches that are not required for 5.10.179

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
saiarcot895 added a commit to saiarcot895/sonic-linux-kernel that referenced this pull request Nov 2, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Fix kversion

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Update to 5.10.179-3.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Disable 6 Mellanox patches as those changes are already included

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Remove Mellanox patches that are not required for 5.10.179

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
StormLiangMS pushed a commit that referenced this pull request Nov 14, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.



* Fix kversion



* Update to 5.10.179-3.



* Disable 6 Mellanox patches as those changes are already included



* Remove Mellanox patches that are not required for 5.10.179

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
yxieca pushed a commit that referenced this pull request Dec 19, 2023
* Update to Linux 5.10.179

One patch needed some changes; all other patches are unchanged.

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Co-authored-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants