Fix false alarm when writing convrate on max6658#82
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 11, 2019
Merged
Fix false alarm when writing convrate on max6658#82lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
We found that the max6658 sometimes issues a false alarm when its convrate is changed, with the current hwmon driver. This workaround will fix it by stopping the conversion before setting the convrate.
Contributor
|
is this a upstream fix? is this a generic fix? |
Contributor
Author
I was thinking that the change would be generic, as it only adds some steps to change the stop/run bit of LM90_REG_R_CONFIG1, which is similar to what has been done in the function lm90_init_client(). But considering that we are not able to test the change on all the chips supported by lm90, maybe it is better to add some if-conditions to make the change only be applied to max6658. I'll make a change. |
Contributor
|
agree. |
dal00
pushed a commit
to kamelnetworks/sonic-linux-kernel
that referenced
this pull request
Jul 20, 2025
…or DualToR config (sonic-net#82) This PR is a required for changing the L3 IP forwarding Behavior to SoC in active-active toplogy. Basically a src IP is added to the SNAT rule so that only packets originating from ToR with src IP as vlan IP get natted by the rule and change the src IP to LoopBack IP However if there are mutiple vlan IP's we only add the source IP as vlan IP, for which the SoC IP belongs to, this PR adds that change. How I did it check the config DB if the ToR is a DualToR and has an SoC IP assigned. put an iptable rule iptables -t nat -A POSTROUTING --destination -j SNAT --to-source " Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found that max6658 sporadically sends a false overtemp alarm during
changing the convrate by hwmon kernel driver. This workaround will fix it by
forcing to stop conversion before setting the convrate. The false alarm will
trigger reboot and we found it on Arista 7170 switch.