Skip to content

Conversation

@SunderB
Copy link
Contributor

@SunderB SunderB commented Aug 2, 2023

This PR fixes a few issues when using the system language:

  • Fix system language detection when the system language is generic English (i.e. has the lang code of "en") - should hopefully fix system language on (OSX, Raspberry Pi) is not properly detected #3215 and fix Incorrect language #3290
  • Only show the language that will be loaded in the confirmation dialog when switching to the system language
  • Only show the language that is currently loaded in the text below the language setting when using the system language
  • Also, add native language name for Arabic

@samaaron samaaron merged commit 67aebad into sonic-pi-net:dev Aug 3, 2023
@samaaron
Copy link
Collaborator

samaaron commented Aug 3, 2023

Brilliant stuff, thanks @SunderB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect language system language on (OSX, Raspberry Pi) is not properly detected

2 participants