Skip to content

chore: remove dead code OracleVMManager#281

Merged
sonikro merged 2 commits into
mainfrom
copilot/remove-dead-code-oraclevmmanager
May 17, 2026
Merged

chore: remove dead code OracleVMManager#281
sonikro merged 2 commits into
mainfrom
copilot/remove-dead-code-oraclevmmanager

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

OracleVMManager was a 266-line Oracle VM implementation entirely superseded by OCIServerManager, kept alive only by a commented-out reference in ServerManagerFactory.ts.

Changes

  • Deleted OracleVMManager.ts and OracleVMManager.test.ts
  • ServerManagerFactory.ts: removed the OracleVMManager import and the dead commented-out return OracleVMManager.create(...) block
  • oracle/index.ts: removed the OracleVMManager barrel re-export

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • npm.jsr.io
    • Triggering command: /usr/local/bin/node node /usr/local/bin/npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 17, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Remove dead code for OracleVMManager chore: remove dead code OracleVMManager May 17, 2026
Copilot AI requested a review from sonikro May 17, 2026 19:31
@sonikro sonikro marked this pull request as ready for review May 17, 2026 19:38
Copilot AI review requested due to automatic review settings May 17, 2026 19:38
@sonikro sonikro enabled auto-merge (rebase) May 17, 2026 19:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused OracleVMManager class (and its test file), which has been fully superseded by OCIServerManager. The only remaining references were a commented-out block in the factory and a barrel re-export, both of which are also cleaned up.

Changes:

  • Delete OracleVMManager.ts and OracleVMManager.test.ts.
  • Remove the OracleVMManager import and commented-out factory branch in ServerManagerFactory.ts.
  • Drop the OracleVMManager re-export from the oracle barrel file.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/providers/src/services/ServerManagerFactory.ts Removes dead import and commented-out fallback creation block.
packages/providers/src/cloud-providers/oracle/OracleVMManager.ts Deletes the obsolete VM manager implementation.
packages/providers/src/cloud-providers/oracle/OracleVMManager.test.ts Deletes the corresponding test file.
packages/providers/src/cloud-providers/oracle/index.ts Removes the barrel re-export of the deleted class.

@sonikro sonikro merged commit d9c4e90 into main May 17, 2026
13 checks passed
@sonikro sonikro deleted the copilot/remove-dead-code-oraclevmmanager branch May 17, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech Debt] Remove dead code: OracleVMManager

3 participants