Urgent fix for Conan build on GCC 5#230
Merged
Merged
Conversation
…e a json syntax issue
…ror, but in some environments this doesn't seem to be the case, so since the error code is rarely useful, just don't log it
garethsb
added a commit
to garethsb/nmos-cpp
that referenced
this pull request
Apr 28, 2022
* for build and dependencies, e.g. sony#197, sony#198, sony#207, sony#211, sony#215, sony#229, sony#230, sony#235, sony#243 * for SDP parser/generator, e.g. sony#201, sony#205, sony#219, sony#241, sony#242, sony#244 * for RQL, e.g. sony#224 * for CI tests, e.g. sony#218, sony#231, sony#239, sony#250
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See conan-io/conan-center-index#8895 (comment).
And the gory details in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66145.
Successful compilation, e.g. https://godbolt.org/x/qr1Yf7oo1, demonstrates that
std::ios_base::failureis derived fromstd::system_errorin some environments with GCC 5, but since the error code is rarely useful, it's pragmatic just to delete this troublesome line of code.(Oh, and a comment fix I had lying around.)