Skip to content

Fix auto revoke feature bug#8

Merged
yanakayus merged 1 commit intosony:mainfrom
yanakayus:fix/fix-for-autoRevokeDuration
Feb 28, 2025
Merged

Fix auto revoke feature bug#8
yanakayus merged 1 commit intosony:mainfrom
yanakayus:fix/fix-for-autoRevokeDuration

Conversation

@yanakayus
Copy link
Copy Markdown
Collaborator

Issue # (if applicable)

Closes #.

🎉 Reason for this change

Fix for auto revoke feature bug

🔀 Description of changes

packages/hub/src/workflows/approval-request/submit.ts

  • Fix for maxDuration format
  • Check autoRevokeDuration is required

apps/web-ui/src/components/approval-flow/requestForm.tsx

  • Fix for auto revoke form

🖨️ Description of how you validated changes

  • Check unit test is passed.
  • I started the web UI on my local environment and confirmed that there are no issues.

👀 Points to be checked especially by reviewers (if any)

🔗 Related links

@yanakayus yanakayus self-assigned this Feb 28, 2025
@yanakayus yanakayus merged commit 2277194 into sony:main Feb 28, 2025
@yanakayus yanakayus deleted the fix/fix-for-autoRevokeDuration branch February 28, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant