fix: correct 2D cross product formula #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cross product formula was incorrect: - Before: p1x * p2x - p1y * p2y (wrong) - After: p1x * p2y - p1y * p2x (correct) The 2D cross product (perp dot product) should compute: A × B = Ax * By - Ay * Bx This returns the z-component of the 3D cross product when treating 2D vectors as 3D vectors with z=0. Also fixed the example comment to show correct result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
p1x * p2x - p1y * p2y(wrong)p1x * p2y - p1y * p2x(correct)The 2D cross product should compute
A × B = Ax * By - Ay * Bx, which returns the z-component of the 3D cross product.Test