refactor: 이미지 업로드 pre-signed 방식으로 변경 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //스탬프 중복 검사체크 | ||
| @Transactional(readOnly = true) | ||
| public boolean checkDuplicateStamp(Long userId, Long missionId) { | ||
| public void checkDuplicateStamp(Long userId, Long missionId) { |
Member
There was a problem hiding this comment.
되게 사소하지만 이러면 더 깔끔할거 같은 느낌!
public void checkDuplicateStamp(Long userId, Long missionId) {
if (stampRepository.existsByUserIdAndMissionId(userId, missionId)) {
throw new BadRequestException(ResponseCode.INVALID_REQUEST);
}
}
Collaborator
Author
There was a problem hiding this comment.
오 저도 이부분 개선하고 싶었는데 감사합니다!
포스트맨 테스트에서는 577ms -> 81ms로 체감이 될 정도로 빨라지긴 했습니다..!
dragontaek-lee
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
기존 이미지 업로드 API들을 pre-signed 방식으로 변경했습니다.
미션 생성하기
스탬프 등록하기, 스탬프 수정하기
🌵 Working Branch
refactor/presigned
🌴 Works
🌱 Related Issue
#57