WDS-125 async select search #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctepan
requested review from
0x009922,
RustemYuzlibaev,
Sociopacific,
stefashkaa and
timofeytrepalin
0x009922
suggested changes
Feb 15, 2023
Contributor
0x009922
left a comment
0x009922
left a comment
There was a problem hiding this comment.
Can you add more tests, including component ones? Not critical by the way.
0x009922
approved these changes
Feb 17, 2023
RustemYuzlibaev
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(after #497)
Text field:
prefixslot - inline elements before input andfilledStateprop to use filled state when prefix presentsSelect:
triggerSearchprop to enable search input in select inputremoteSearchprop that disables default search behaviour