Merlin 1.2.1: Fixed Ruff checks and applied single responsability principal to lights setup.#4
Merged
Jake-Pullen merged 1 commit intomainfrom Oct 27, 2025
Merged
Conversation
…r memory.py and hue_config_setup.py for improved readability and structure
Jake-Pullen
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors several modules to improve code clarity, maintainability, and consistency across the project, especially in configuration handling and the memory expert agent. It introduces better type annotations, enhances docstrings, and modularizes configuration update logic for Hue lights. Minor fixes and formatting improvements are also included.
Memory Agent and Expert Improvements
src/experts/memory.pyto clarify docstrings, update type annotations to use modern Python syntax (e.g.,dict[str, Any]), and improve method documentation and naming for consistency. [1] [2] [3]consult_memory_expertmethod docstring insrc/experts/orchestrator.pyfor better guidance and readability.Hue Lights Configuration Refactor
src/setup/lights/hue_config_setup.pyby modularizing config file loading, updating, and saving into helper functions (_load_config_file,_update_lights_config,_update_rooms_config,_save_config_file,_print_update_summary) and improved the mainupdate_configfunction for better maintainability. [1] [2]hue_lightstoHueLightswith improved docstrings and initialization logic.General Code Quality and Consistency
src/config/app_config.py,src/config/user_config_template.py), including alphabetizing imports and switching to double quotes for string literals. [1] [2]Versioning
1.2.0to1.2.1inpyproject.tomlto reflect these improvements.