Conversation
Contributor
Author
|
I considered updating the code to remove the explicit cache, and provide an option to not-cache the RA DECs altogether... but maybe it makes sense to limit scope creep. |
Member
|
And even though I'm now fully convinced that returning from within a context block will run the |
This was referenced Jan 4, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce peak memory use by reading just the RA and DEC fields to get them (used for indexing into the agasc).
Interface impacts
Testing
Unit tests
Independent check of unit tests by @taldcroft:
Functional tests
I looked at this before and after with memory profiler output and confirmed that the change means that, using the proseco agasc file as an example, only the 60Mb columns are read into memory instead of the file (which peaks more at ~600Mb).