Stop fetching and parsing thermal constraint file#68
Conversation
|
Given scope, I don't think we need to capture more test outputs etc in the PR. |
|
There are probably a few other places where text warnings could be updated to remove anything about "thermal violation events". |
|
Yeah, I see at least a couple of |
|
Otherwise this looks relatively uncontroversial. It's been awhile, so (if it's not too complicated) could you remind me of how you actually ran this in a test version? (And put this in the PR description in a Functional testing section). And as always it is useful to put in a little backstory about why you are doing this. |
|
Right, so for scope if the thermal constraint report isn't available are there any thermal violations that could be tracked by the code? |
|
With regard to testing, we've got setup notes on the wiki https://github.com/sot/arc/wiki/Set-up-test-Replan-Central . I figured that there might be other fixes in a replan central release that would go to FSDS and get more test output review. |
I don't believe there are any thermal violations in the PCAD constraint report. |
Did you have some other changes in mind? Otherwise given the fairly slow release pace for |
|
Thanks @malgosias ! |
Description
Stop fetching and parsing thermal constraint file.
The thermal constraint file is no longer created by FOT thermal as the outputs are no longer relevant / no longer based on models used by the FOT. The file used to be included in the FOT approved products outputs.
Testing
In a test version (see wiki for howto) this PR removed the warning "Could not find constraints file for any load version of therm_JAN1022" from the top and the load link was appropriately populated with the link to the approved JAN1022A directory.