Remove constraint violations

[taldcroft]

Description

The constraint violations reported in Replan Central are no longer valid:

• SCS-107 no longer stops maneuvers, so the attitude-based and momentum violations are incorrect.
• Thermal violations are likewise inaccurate.
• Bright star hold is no longer allowed as a safing action; instead Normal Sun Mode is activated if stars are lost. That means the constraint violations for that attitude are not relevant.

The expectation is that the load product generation will remove these constraints from the report in a future release. This PR fixes Replan Central in advance of that change.

In the test outputs below, the Earth Violation and High Momentum constraint events (seen in flight) are no longer generated:

• https://cxc.cfa.harvard.edu/mta/ASPECT/tests/arc/pr88/arc3-test/
• https://cxc.cfa.harvard.edu/mta/ASPECT/tests/arc/pr88/arc3-flight/

The red notices in the test output for HRC proxy data stale, P4GM data stale, and P41GM data stale are expected as the test setup used stale data for these.

Interface impacts

Incorrect constraint events are removed.

Functional testing

This testing was run with data files left over from #87 (which is why there are warnings about stale data unrelated to the changes in the PR).

From the git repository in this branch:

# Environment setup
export ska_dir=/export/tom/arc3_test
source ${ska_dir}/bin/activate
source ${ska_dir}/bin/ska_envs.sh

# Make sure the outputs are going to an expected directory
echo $SKA_DATA

# Install
make install

# Run through perl jobs in task schedule. Python jobs (data collection, timelines) not impacted.
# This uses data files left over from PR 87.
${SKA_SHARE}/arc3/get_iFOT_events.pl
${SKA_SHARE}/arc3/get_web_content.pl
${SKA_SHARE}/arc3/arc.pl
${SKA_SHARE}/arc3/arc.pl -config arc3:arc_ops

# Copy test and current flight outputs for PR test documentation
mkdir -p /proj/sot/ska/www/ASPECT/tests/arc/pr88/arc3-test
rsync -av $SKA/www/ASPECT/arc3/ /proj/sot/ska/www/ASPECT/tests/arc/pr88/arc3-test/
rsync -av /proj/sot/ska/ASPECT/arc3/  /proj/sot/ska/www/ASPECT/tests/arc/pr88/arc3-flight/

[jeanconn]

I think get_obsid_event can go too.

[jeanconn]

I assume the "HRC proxy data stale
P4GM data stale
P41GM data stale"
on the test page is unrelated, but since I don't understand it based on the test setup, I can't approve the PR. This probably just needs a new sync of the data and another run of the test code.

[jeanconn]

Test output shows unexplained missing/stale data.

[taldcroft]

I assume the "HRC proxy data stale P4GM data stale P41GM data stale" on the test page is unrelated, but since I don't understand it based on the test setup, I can't approve the PR. This probably just needs a new sync of the data and another run of the test code.

The test functional docs say This uses data files left over from PR 87. This explains the stale data as being expected and unrelated to the PR.

[jeanconn]

OK, though I think test setup comments like that should probably live outside of the copy-paste of shell commands and test deviations should be called out in the description.