Conversation
Contributor
Author
|
Todo:
|
taldcroft
requested changes
Feb 5, 2025
jeanconn
force-pushed
the
new-solar-flare
branch
from
a4a58fe to
47853ef
Compare
jeanconn
force-pushed
the
new-solar-flare
branch
from
47853ef to
ccc61b5
Compare
Contributor
Author
|
I've updated this and put out test output to the icxc link in the Description. |
Member
|
The solar flare image is too big. Make it about as tall as the solar wind data plot above. |
Contributor
Author
|
OK. |
Contributor
Author
|
Done. |
taldcroft
requested changes
Feb 6, 2025
Member
taldcroft
left a comment
taldcroft
left a comment
There was a problem hiding this comment.
Looks good, just one suggested change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the solar flare image from https://www.solen.info/solar/index.html
This is an idea to supersede #84
Interface impacts
This uses a new image file and new link for the solar flare information.
Functional testing
Locally I've just confirmed the new script fetches the image file.
I then set up a test ska following the wiki instructions and put the task_schedule output to
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/arc/arc-pr90/