Update ephem_stk code and testing for kadi.occweb built-in retry#283
Merged
Update ephem_stk code and testing for kadi.occweb built-in retry#283
Conversation
2 tasks
jeanconn
approved these changes
Nov 13, 2025
Contributor
jeanconn
left a comment
There was a problem hiding this comment.
LGTM - it is a bit weird to monkey patch the defaults in ska_helpers to do test_stk_ephem_timeout, but I see where it can work as a convenience in this case since there's no configureable for get_occweb.
javierggt
approved these changes
Nov 14, 2025
Member
Author
|
Yeah, the monkeypatch is a bit odd, but that was sort of my point in the other PR that this should be inconvenient and probably only something done in testing. |
This was referenced Nov 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the code to fetch the STK ephemeris in conjunction with sot/kadi#366. The
kadi.occweb.get_*functions now automatically retry.It also reduces the timeout for the
occweb.get_occweb_dircall to 5 sec. If it can't get the result in 5 second then wait and try again.This also adds an explicit test of the retry functionality via a new
MockFuncFailureclass that is added inska_helpers.retry.Requires
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.