Explicit complete_intervals=True in logical intervals + code tidy#263
Merged
Explicit complete_intervals=True in logical intervals + code tidy#263
Conversation
javierggt
approved these changes
Dec 8, 2022
Contributor
javierggt
left a comment
javierggt
left a comment
There was a problem hiding this comment.
The changes seem good to me. At first I looked at the diffs "color-blindly" (not noticing the import_ska part was red) and started wondering why you were adding that. Was happy to realize you were removing it.
I ran the unit tests, but I would note that the unit tests would not have caught the change in eng_archive.
This was referenced Jan 4, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
complete_intervals=Trueto a key call tological_intervalsthat defines the creation of kadi events. Previously this was relying on the default value of that kwarg being True. Since that default is being changed in sot/cheta#243, here we need to be explicit.While in the code I noticed that an ugly hack of the
@import_skadecorator is no long needed now that the kadi package does not provide a web server. This hack doesn't play well with IDEs (code introspection doesn't work).Interface impacts
None.
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.