Add type field to Dump event class and update docs and process notes#264
Merged
Add type field to Dump event class and update docs and process notes#264
type field to Dump event class and update docs and process notes#264Conversation
taldcroft
changed the title
type field to Dump event class and update docs and process notes
Contributor
|
Does this line do anything at this point? |
jeanconn
reviewed
Dec 16, 2022
Contributor
jeanconn
left a comment
jeanconn
left a comment
There was a problem hiding this comment.
Other than wondering about event_val = 'GRND' this looks good to me.
Member
Author
|
I'm pretty sure |
jeanconn
approved these changes
Dec 19, 2022
Contributor
jeanconn
left a comment
jeanconn
left a comment
There was a problem hiding this comment.
OK, if the defunct event_val = 'GRND' is benign, I don't have other issues with this. Make sense.
This was referenced Jan 3, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The primary driver for this PR is to add a
typefield to the momentumDumpevent which indicates if this dump was ground commanded or autonomous.In doing this I noted that the process notes files were out of date and substantively wrong in many places, so I took the opportunity to do some re-organization and clean-up.
Interface impacts
Adds a
typefield todumps, but is otherwise back compatible. In particular the new database works with old code.Testing
Unit tests
Independent check of unit tests by Jean (with this PR's events3.db3)
Functional tests
The update process now described in
NOTES.events_maintain.rstwas followed end-to-end. This includes functional testing:Dumpevents with thetypefield.dumps.The new
events3.db3file is available on HEAD in/proj/sot/ska/data/kadi/rc.