Skip to content

Update fids in a test for proseco PR410#227

Merged
jeanconn merged 1 commit intomasterfrom
guide-opt-fid
Jan 15, 2026
Merged

Update fids in a test for proseco PR410#227
jeanconn merged 1 commit intomasterfrom
guide-opt-fid

Conversation

@jeanconn
Copy link
Copy Markdown
Contributor

@jeanconn jeanconn commented Jan 15, 2026

Description

Update fids in a test that have changed due to proseco PR410 (Optimize fid lights for guide stars).

This updates what amounts to a regression test "answer" for a fid selection change due to PR410 which is expected.

Test update only

Interface impacts

Testing

Environment with sot/proseco#410

Unit tests

  • Mac
(ska3-flight-2026.1rc1) flame:sparkles jean$ git rev-parse HEAD
c4b567b52e6721a2af6dc5143b72f0a75852655c
(ska3-flight-2026.1rc1) flame:sparkles jean$ export PYTHONPATH=/Users/jean/git/proseco
(ska3-flight-2026.1rc1) flame:sparkles jean$ pytest
======================================================= test session starts ========================================================
platform darwin -- Python 3.13.10, pytest-9.0.1, pluggy-1.6.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: anyio-4.12.0, timeout-2.4.0
collected 128 items                                                                                                                

sparkles/tests/test_checks.py .............................................................................................. [ 73%]
....                                                                                                                         [ 76%]
sparkles/tests/test_find_er_catalog.py .....                                                                                 [ 80%]
sparkles/tests/test_review.py .....................                                                                          [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                            [100%]

======================================================= 128 passed in 36.02s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn merged commit 76b12c5 into master Jan 15, 2026
2 checks passed
@javierggt javierggt deleted the guide-opt-fid branch January 15, 2026 15:52
This was referenced Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants