Allow using maude for thermal model source data#397
Merged
Conversation
0f6ef77 to
41b5933
Compare
taldcroft
reviewed
Dec 19, 2022
Contributor
Author
|
I updated per comments and reran the testing. I note the testing no longer shows much difference between the telemetry sources in the temperature plot as the DEC1922 loads are well underway. |
taldcroft
approved these changes
Dec 23, 2022
Member
taldcroft
left a comment
There was a problem hiding this comment.
Looks great now. I tested this on DEC2622 and it worked as expected. In particular my cheta archive was a few days old and there was a substantial difference in the propagation time. This is great and the -maude flag will be my default going forward.
This was referenced Jan 6, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow using MAUDE for thermal model source data, with automatic selection of MAUDE if eng_archive data is not available. This is handy on my laptop as I no longer bother with syncing the archive. Adds an option to use maude for other systems when more up-to-date telemetry is desired.
While making it work on the laptop, I also noticed that the plotting routing was always using miniagasc.h5 instead of the supplied agasc_file, so added a fix for that.
Interface impacts
Machines without AACCCDPT in their cheta archive will fallback to using MAUDE/maude for initial conditions for the ACA thermal model. Also adds the "-maude" option to allow users to use MAUDE/maude if preferred (but does not change default unless the archive is missing or broken).
Testing
Unit tests
Functional tests
Ran on my OSX laptop fine with AACCCDPT no longer in eng_archive.
On fido tested with and without maude option and compared the without option to flight with expected results:
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/DEC1922/oflsa -maude -out dec1922t_maude
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/dec1922t_maude.html
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/DEC1922/oflsa -out dec1922t_cxc
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/dec1922t_cxc.html
starcheck -dir /data/mpcrit1/mplogs/2022/DEC1922/oflsa -out dec1922_flight
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/dec1922_flight.html
diff
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/diff.html