Skip to content

Allow using maude for thermal model source data#397

Merged
jeanconn merged 8 commits intomasterfrom
maude-fallback
Dec 23, 2022
Merged

Allow using maude for thermal model source data#397
jeanconn merged 8 commits intomasterfrom
maude-fallback

Conversation

@jeanconn
Copy link
Copy Markdown
Contributor

@jeanconn jeanconn commented Oct 3, 2022

Description

Allow using MAUDE for thermal model source data, with automatic selection of MAUDE if eng_archive data is not available. This is handy on my laptop as I no longer bother with syncing the archive. Adds an option to use maude for other systems when more up-to-date telemetry is desired.

While making it work on the laptop, I also noticed that the plotting routing was always using miniagasc.h5 instead of the supplied agasc_file, so added a fix for that.

Interface impacts

Machines without AACCCDPT in their cheta archive will fallback to using MAUDE/maude for initial conditions for the ACA thermal model. Also adds the "-maude" option to allow users to use MAUDE/maude if preferred (but does not change default unless the archive is missing or broken).

Testing

Unit tests

  • No unit tests

Functional tests

Ran on my OSX laptop fine with AACCCDPT no longer in eng_archive.

On fido tested with and without maude option and compared the without option to flight with expected results:

/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/DEC1922/oflsa -maude -out dec1922t_maude

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/dec1922t_maude.html

/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/DEC1922/oflsa -out dec1922t_cxc

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/dec1922t_cxc.html

starcheck -dir /data/mpcrit1/mplogs/2022/DEC1922/oflsa -out dec1922_flight

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/dec1922_flight.html

diff

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr397/diff.html

@jeanconn jeanconn changed the title WIP: Fallback to using maude for thermal model source data Fallback to using maude for thermal model source data Dec 15, 2022
@jeanconn jeanconn requested a review from taldcroft December 15, 2022 20:02
Copy link
Copy Markdown
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Comment thread starcheck/calc_ccd_temps.py Outdated
Comment thread starcheck/calc_ccd_temps.py Outdated
@taldcroft taldcroft changed the title Fallback to using maude for thermal model source data Allow using maude for thermal model source data Dec 19, 2022
@jeanconn
Copy link
Copy Markdown
Contributor Author

I updated per comments and reran the testing. I note the testing no longer shows much difference between the telemetry sources in the temperature plot as the DEC1922 loads are well underway.

Copy link
Copy Markdown
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. I tested this on DEC2622 and it worked as expected. In particular my cheta archive was a few days old and there was a substantial difference in the propagation time. This is great and the -maude flag will be my default going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants