Skip to content

Update for expanded high-IR zone #413

Merged
jeanconn merged 2 commits intomasterfrom
expanded-ir-zone
Jul 7, 2023
Merged

Update for expanded high-IR zone #413
jeanconn merged 2 commits intomasterfrom
expanded-ir-zone

Conversation

@jeanconn
Copy link
Copy Markdown
Contributor

@jeanconn jeanconn commented Jun 22, 2023

Description

Extend the high IR zone to 20 minutes after perigee for the high IR zone keep-out check.

Interface impacts

Testing

Unit tests

  • No unit tests

Functional tests

Ran on one week (JUN0523) with the previous pre-perigee zone, and two weeks (JUN1923 and JUN2623) with the new 30-before-20-after zone in products.

Output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr413

jeanconn-fido> more run.sh
# JUN0523 week 
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUN0523/oflsa -out jun0523a_test
/proj/sot/ska3/flight/bin/starcheck -dir /data/mpcrit1/mplogs/2023/JUN0523/oflsa -out jun0523a_flight
/proj/sot/ska/bin/diff2html jun0523a_flight.txt jun0523a_test.txt > jun0523a_diff.html

# JUN1923 week 
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUN1923/oflsa -out jun1923a_test
/proj/sot/ska3/flight/bin/starcheck -dir /data/mpcrit1/mplogs/2023/JUN1923/oflsa -out jun1923a_flight
/proj/sot/ska/bin/diff2html jun1923a_flight.txt jun1923a_test.txt > jun1923a_diff.html

# JUN2623 week 
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2023/JUN2623/oflsa -out jun2623a_test
/proj/sot/ska3/flight/bin/starcheck -dir /data/mpcrit1/mplogs/2023/JUN2623/oflsa -out jun2623a_flight
/proj/sot/ska/bin/diff2html jun2623a_flight.txt jun2623a_test.txt > jun2623a_diff.html

@taldcroft taldcroft changed the title WIP: Update for current zone WIP: Update for to expand high-IR zone Jun 22, 2023
@taldcroft
Copy link
Copy Markdown
Member

At first look this seems OK.

@jeanconn
Copy link
Copy Markdown
Contributor Author

For functional testing, it probably makes sense to just show this week passing and some previous week (before the zone change) failing. I don't think we care about regression testing here -- and thus don't care about making this date dependent or adding a cmdline option.

@jeanconn jeanconn changed the title WIP: Update for to expand high-IR zone WIP: Update for expanded high-IR zone Jun 23, 2023
@jeanconn jeanconn changed the title WIP: Update for expanded high-IR zone Update for expanded high-IR zone Jun 28, 2023
@jeanconn jeanconn requested a review from taldcroft June 28, 2023 01:02
@jeanconn jeanconn requested a review from javierggt July 5, 2023 17:02
Copy link
Copy Markdown
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanconn jeanconn merged commit 77ef4c3 into master Jul 7, 2023
@jeanconn jeanconn deleted the expanded-ir-zone branch July 7, 2023 14:42
@javierggt javierggt mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants