Conversation
Member
|
At first look this seems OK. |
Contributor
Author
|
For functional testing, it probably makes sense to just show this week passing and some previous week (before the zone change) failing. I don't think we care about regression testing here -- and thus don't care about making this date dependent or adding a cmdline option. |
This was referenced Jul 11, 2023
Merged
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend the high IR zone to 20 minutes after perigee for the high IR zone keep-out check.
Interface impacts
Testing
Unit tests
Functional tests
Ran on one week (JUN0523) with the previous pre-perigee zone, and two weeks (JUN1923 and JUN2623) with the new 30-before-20-after zone in products.
Output at https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck-pr413