Skip to content

Allow guide count of 3.5 with creep-away#460

Merged
jeanconn merged 5 commits intomasterfrom
creep-3.5
Dec 10, 2025
Merged

Allow guide count of 3.5 with creep-away#460
jeanconn merged 5 commits intomasterfrom
creep-3.5

Conversation

@jeanconn
Copy link
Copy Markdown
Contributor

@jeanconn jeanconn commented Nov 26, 2025

Description

Allow guide count of 3.5 with creep-away to be consistent with current requirements.

Fixes #459

Interface impacts

Testing

Unit tests

  • Mac
(latest) flame:starcheck jean$ pytest
======================================================================= test session starts ========================================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 14 items                                                                                                                                                 

starcheck/tests/test_state_checks.py .............                                                                                                           [ 92%]
starcheck/tests/test_utils.py .                                                                                                                              [100%]

======================================================================== 14 passed in 4.41s ========================================================================
(latest) flame:starcheck jean$ git rev-parse HEAD
68c559f5533db722ae79ca5e6712ff6a6558d6cc

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Rerun of DEC0125A shows the new statement "Guide count of 3.5 < 4.0 but uses creep-away"

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/pr460/dec0125a_test.html#obsid29956

And the critical from flight is gone.

https://icxc.cfa.harvard.edu/mp/mplogs/2025/DEC0125/oflsa/starcheck.html#obsid29956

}

if (($self->{obsid} < 38000) & ($creep_away) & ($guide_count < 4.0) & ($guide_count >= 3.5)) {
push @{ $self->{yellow_warn} },
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an "info" statement instead of "yellow_warn" but I figured this is rare enough to rise to the "just a bit more attention" the yellow warn gives.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@jeanconn jeanconn marked this pull request as ready for review December 2, 2025 21:46
@jeanconn jeanconn requested a review from Copilot December 2, 2025 21:46

This comment was marked as resolved.

jeanconn and others added 2 commits December 2, 2025 17:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@jeanconn jeanconn merged commit 200dc11 into master Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow guide count down to 3.5 if creep-away used

3 participants