Skip to content

Do checks for optically bright planets#462

Draft
jeanconn wants to merge 13 commits into
masterfrom
jupiter2
Draft

Do checks for optically bright planets#462
jeanconn wants to merge 13 commits into
masterfrom
jupiter2

Conversation

@jeanconn
Copy link
Copy Markdown
Contributor

@jeanconn jeanconn commented May 13, 2026

Description

This branch extends starcheck’s planet handling from plot-only visibility to review output.

Before this change, starcheck plots would display planet positions (via chandra_aca plotting support), but starcheck did not run planet checks. With this change, starcheck now runs the sparkles planet checks during processing and emits text messages in the starcheck report:

  1. Warning/critical-style messages for planet-related risk conditions
  2. Informational statements when planets are detected in the check window
  3. Coverage for planets within 2 degrees of pointing and additional checks for objects on-CCD
  4. Handles two-fid catalogs with planet-required-full-mitigation

Additional changes (separate from planet warning behavior)

  1. processing summary parsing improvement for maneuver matching
    For pre-2020 ER-style/non-numeric dot obsid cases, maneuver setup now uses processing-summary content to map dot obsid values to numeric obsids before matching MP_TARGQUAT maneuvers. This makes maneuver association more robust for older loads. (this is largely done so that earlier loads with planets can be successfully run in modern starcheck for testing, but the changes are benign for modern loads).

  2. Debug catalog pickle output
    A new command-line option allows saving generated proseco catalogs to a pickle file for debugging/regression analysis workflows.

  3. Proseco argument enrichment
    Starcheck now passes additional context (including duration and target name) into the proseco/sparkles path used for these checks.

Requirements
sot/chandra_aca#203
sot/proseco#415
sot/sparkles#229

Interface impacts

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Regression testing via a set of weekly schedules with known planets:

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-planets/combined_diff.txt

Functional testing is in the sparkles PR.

@jeanconn jeanconn mentioned this pull request May 13, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant