Correct some typos/out-of-sync in docs#669
Merged
Merged
Conversation
Includes a bug fix for a bug I ran into. This is probably common on Macs with Retina displays, which have a default resolution of 3024 x 1964 for the 14"
mud2monarch
commented
May 4, 2026
|
|
||
| This is where we configure the `surface`. We need the surface to be configured before we can do anything with it. We set the `is_surface_configured` flag to true here and we'll check it in the `render()` function. | ||
|
|
||
| Note that the max supported dimension in WebGL is 2048 px. If you have a larger display, you must cap the height and width, e.g.: |
Contributor
Author
There was a problem hiding this comment.
Relevant for people with big monitors, also relevant for people with high-res displays, e.g., this is a bug I encountered on my M4 MBP
mud2monarch
commented
May 4, 2026
| queue: wgpu::Queue, | ||
| config: wgpu::SurfaceConfiguration, | ||
| is_surface_configured: bool, | ||
| window: Arc<Window>, |
Contributor
Author
sotrh
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going through this tutorial and greatly appreciate it!!
Most of it is up-to-date, but some parts are out-of-sync or caused bugs.