Skip to content

Fix: Fix limit function for grading table fetch function #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix: Fix limit function for grading table fetch function #1190

merged 2 commits into from
Sep 23, 2024

Conversation

@GabrielCWT
Copy link
Contributor

@GabrielCWT GabrielCWT commented Sep 22, 2024

  • Changes atom to use correct atom (page_size instead of limit)
  • Implement tests for pagination to prevent this from happening again

@GabrielCWT GabrielCWT self-assigned this Sep 22, 2024
@coveralls
Copy link

coveralls commented Sep 22, 2024

Coverage Status

coverage: 94.326%. remained the same
when pulling 4d66230 on GabrielCWT:fix/grading-limit-query
into b02b43c on source-academy:master.

RichDom2185
RichDom2185 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit e33b6c0 into source-academy:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees

@GabrielCWT GabrielCWT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GabrielCWT @coveralls @RichDom2185