Skip to content

Upgrade to Elixir 1.8 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiachen247 merged 4 commits into from
Mar 6, 2019
Merged

Upgrade to Elixir 1.8 #343

jiachen247 merged 4 commits into from
Mar 6, 2019

Conversation

@jiachen247
Copy link
Contributor

@jiachen247 jiachen247 commented Mar 6, 2019 •
edited by indocomsoft
Loading

bumped que, inch and sentry

Fixes #189

@jiachen247 jiachen247 requested a review from indocomsoft March 6, 2019 05:10
@jiachen247 jiachen247 mentioned this pull request Mar 6, 2019
Closed
@jiachen247
Upgrade to Elixir 1.8
2c2ee6c 
bumped que, inch and sentry
This was referenced Mar 6, 2019
Closed
Closed
Closed
@coveralls
Copy link

coveralls commented Mar 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 98.454%
Files with Coverage Reduction New Missed Lines %
lib/cadet/jobs/xml_parser.ex 1 98.59%
lib/cadet/jobs/updater/CS1101S.ex 1 94.12%
Totals Coverage Status
Change from base Build 2272: -0.2%
Covered Lines: 828
Relevant Lines: 841
💛 - Coveralls

@indocomsoft
Copy link
Member

indocomsoft commented Mar 6, 2019

Fixes #189

indocomsoft
indocomsoft requested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add in the README, requirement: Elixir 1.8

@indocomsoft
Copy link
Member

indocomsoft commented Mar 6, 2019

Otherwise LGTM!

indocomsoft
indocomsoft approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@indocomsoft indocomsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiachen247 jiachen247 merged commit 8954f5e into master Mar 6, 2019
This was referenced Mar 6, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indocomsoft indocomsoft indocomsoft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiachen247 @coveralls @indocomsoft