-
Notifications
You must be signed in to change notification settings - Fork 56
Add autograding results to gradingview #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autograding results to gradingview #381
Conversation
Sync with Master
Merge master from source-adacemy/cadet
Pull Request Test Coverage Report for Build 2458
💛 - Coveralls |
jiachen247
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyy shuming!! PR looks good!! love how small it is :-)
-
Everytime we change the view layer we have to update our swagger documentation they can be found in the respective controllers and accessed over
/swaggeron the backend. -
Would be nice to have a little writeup in the PR to know what the PR is intended for!! so we can look back and make sense of it and so the reviewer sort of knows what to look out for!!
But other than that good job!! will take a look at the frontend next haha cheers :-)
| end | ||
|
|
||
| defp build_result(result) do | ||
| def build_result(result) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this belongs in view_helpers now since its being shared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should still be fine leaving it under assessments_view? At most only grading_view and assessments_view require build_result so I don't think it makes sense to isolate the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pattern we have been adopting is all shared methods go into the view helpers so our views dont couple or depend on other views!! lets try to be consistent with the codebase okay!!
jiachen247
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.