Skip to content

Integrate file upload system #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiayushe merged 18 commits into from
Aug 11, 2019
Merged

Integrate file upload system #463

jiayushe merged 18 commits into from
Aug 11, 2019

Conversation

@jiayushe
Copy link
Contributor

@jiayushe jiayushe commented Aug 10, 2019

@jiayushe jiayushe mentioned this pull request Aug 10, 2019
Merged
@coveralls
Copy link

coveralls commented Aug 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2623

  • 31 of 75 (41.33%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.8%) to 91.88%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/cadet_web/router.ex 0 1 0.0%
lib/cadet_web/views/material_view.ex 0 6 0.0%
lib/cadet_web/controllers/category_controller.ex 0 16 0.0%
lib/cadet_web/controllers/material_controller.ex 0 21 0.0%
Totals Coverage Status
Change from base Build 2614: -3.8%
Covered Lines: 1007
Relevant Lines: 1096
💛 - Coveralls

@jiayushe jiayushe requested a review from geshuming August 11, 2019 06:39
@jiayushe jiayushe merged commit 8bf213e into source-academy:master Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geshuming geshuming Awaiting requested review from geshuming

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiayushe @coveralls @ZiHawkEye