Skip to content

Remove unused vars #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Remove unused vars #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion priv/repo/migrations/20210531155751_multitenant_upgrade.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ defmodule Cadet.Repo.Migrations.MultitenantUpgrade do
use Ecto.Migration
import Ecto.Query

alias Cadet.Accounts.{CourseRegistration, Notification, Role, User}
alias Cadet.Accounts.{CourseRegistration, Notification}
alias Cadet.Assessments.{Answer, Assessment, Question, Submission, SubmissionVotes}
alias Cadet.Courses.{AssessmentConfig, Course, Group, Sourcecast}
alias Cadet.Repo
Expand Down
2 changes: 1 addition & 1 deletion priv/repo/migrations/20210716073359_update_achievement.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
defmodule Cadet.Repo.Migrations.UpdateAchievement do
use Ecto.Migration
import Ecto.Query, only: [from: 2, where: 2]
import Ecto.Query, only: [from: 2]

def change do
alter table(:achievements) do
Expand Down
7 changes: 4 additions & 3 deletions priv/repo/seeds.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if Cadet.Env.env() == :dev do
studentc1 = insert(:user, %{latest_viewed_course: course1})
# CourseRegistration and Group
avenger1_cr = insert(:course_registration, %{user: avenger1, course: course1, role: :staff})
admin1_cr = insert(:course_registration, %{user: admin1, course: course1, role: :admin})
_admin1_cr = insert(:course_registration, %{user: admin1, course: course1, role: :admin})
group = insert(:group, %{leader: avenger1_cr})

student1a_cr =
Expand All @@ -49,15 +49,16 @@ if Cadet.Env.env() == :dev do

students = [student1a_cr, student1b_cr, student1c_cr]

admin2cr = insert(:course_registration, %{user: studenta1admin2, course: course2, role: :admin})
_admin2cr =
insert(:course_registration, %{user: studenta1admin2, course: course2, role: :admin})

# Assessments
for i <- 1..5 do
config = insert(:assessment_config, %{type: "Mission#{i}", order: i, course: course1})
assessment = insert(:assessment, %{is_published: true, config: config, course: course1})

config2 = insert(:assessment_config, %{type: "Homework#{i}", order: i, course: course2})
assessment2 = insert(:assessment, %{is_published: true, config: config2, course: course2})
_assessment2 = insert(:assessment, %{is_published: true, config: config2, course: course2})

programming_questions =
insert_list(3, :programming_question, %{
Expand Down