Removing unique score constraint for contest entries from backend (in preparation for frontend PR) #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
YaleChen299
requested changes
Apr 9, 2023
Contributor
YaleChen299
left a comment
YaleChen299
left a comment
There was a problem hiding this comment.
LTGM! Thank you for the good work! Just some minor nits for comments.
lib/cadet/assessments/assessments.ex
Outdated
| |> case do | ||
| {:ok, _result} -> {:ok, nil} | ||
| {:error, _name, _changset, _error} -> {:error, :vote_not_unique} | ||
| # error type has been changed to :invalid_vote |
Contributor
There was a problem hiding this comment.
I think we can remove this comment since we have reviewed this PR.
lib/cadet/assessments/assessments.ex
Outdated
|
|
||
| {:error, :vote_not_unique} -> | ||
| {:error, {:bad_request, "Invalid vote or vote is not unique! Vote is not saved."}} | ||
| # Description changed from :vote_not_unique and corresponding message changed. |
Contributor
There was a problem hiding this comment.
It is Okay to remove the comment, since other developer might be buffled by the word "change", since they might not be following this project. This change history is captured in github so it is okay.
| @required_fields ~w(voter_id submission_id question_id)a | ||
| @optional_fields ~w(score)a | ||
|
|
||
| # |> unique_constraint(:unique, name: :unique_score) (Unique constraint removed) |
Contributor
There was a problem hiding this comment.
For here, change the comment to a factual statement like "there is no unique constraint...blah blah".
| {:error, changeset} = Repo.insert(second_entry) | ||
| refute changeset.valid? | ||
| end | ||
| # Removed test for unique submission vote |
YaleChen299
approved these changes
Apr 9, 2023
kjw142857
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to remove unique score checking for contest entries in backend in preparation for our frontend pull request to implement our contest voting tierlist, which accepts non-unique scores as submissions.
Am changing these 5 files:
assessments.ex - removed reference to non-unique submission votes causing an error and changed corresponding error message.
submission_votes_test.exs - removed test for unique votes.
submission_votes.ex - commented out unique score checker (unique_constraint)
Added new migration file 20230331010500_remove_unique_score_constraint.exs - reversible migration that removes the unique score index from the database, such that it can accept non-unique score entries.
answer_controller_test.exs - removed test case that checked for duplicate score, changed test case to check for updated error message in assessments.ex