Encode chapter and variant separately in Share URL #1065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we create the Share URL for the Non-deterministic and Concurrent variants, we encode the chapter and variant information together in one string.
For example, if the playground was using
Source 3 Non-Det, then then Share URL will looklike this
https://source-academy.github.io/playground#chap=3_Non_Det&exec=1000&ext=NONE&prgrm=IYWwRgFAjAlA3EANote the string
#chap=3_Non_Detin the URL.Instead of this, we can encode the chapter and variant separately.
So, the url will look like:
https://source-academy.github.io/playground#chap=3&exec=1000&ext=NONE&prgrm=IYWwRgFAjAlA3EA&variant=non-detThis PR reduces the steps needed to add a new language variant.
The Share URL will automatically support any language variants added into the
sourceLangaugesarray insrc/reducers/states.ts.Note: The
variantfield in the Share URL is optionalIf the URL does not have a
variant, the playground will use thedefaultvariant.This ensures the Share URL is backward compatible