Skip to content

Abstract Assessment Overviews #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 21, 2018
Merged

Abstract Assessment Overviews #119

merged 15 commits into from
Jun 21, 2018

Conversation

@remo5000
Copy link
Contributor

@remo5000 remo5000 commented Jun 20, 2018

Features

  • MissionsContainer and Missions component have been renamed to AssessmentsListing...
  • Pressing the different assessment buttons (Missions, Sidequests, etc.) now filter and display the retrieved listings.

To do next

  • Allow Assessments to take in a category prop

@remo5000 remo5000 requested a review from ning-y June 20, 2018 14:56
@coveralls
Copy link

coveralls commented Jun 20, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 39

  • 14 of 18 (77.78%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 29.935%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/academy/index.tsx 3 4 75.0%
src/components/assessment/index.tsx 0 1 0.0%
src/containers/assessment/AssessmentListingContainer.ts 3 5 60.0%
Totals Coverage Status
Change from base Build 30: -0.02%
Covered Lines: 1061
Relevant Lines: 3109
💛 - Coveralls

remo5000 added 2 commits June 21, 2018 10:55
@remo5000
Change routing for mission assessment
81d3072
@remo5000
Move assessment container files into a folder
11ac599 
If there is a better way, we should abandon relative addressing
@ning-y ning-y merged commit 25d5ddc into master Jun 21, 2018
@ning-y ning-y deleted the assessment-overview branch June 22, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ning-y ning-y ning-y approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remo5000 @coveralls @ning-y