Skip to content

Fix group switching for admins #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix group switching for admins #2661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/pages/academy/grading/Grading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ const Grading: React.FC = () => {

const isAdmin = role === Role.Admin;
const [showAllGroups, setShowAllGroups] = useState(isAdmin || group === null);
const handleShowAllGroups = (value: boolean) => {
// Admins will always see all groups regardless
setShowAllGroups(isAdmin || value);
};
const groupOptions = [
{ value: false, label: 'my groups' },
{ value: true, label: 'all groups' }
Expand Down Expand Up @@ -122,7 +118,7 @@ const Grading: React.FC = () => {
<SimpleDropdown
options={groupOptions}
defaultValue={showAllGroups}
onClick={handleShowAllGroups}
onClick={setShowAllGroups}
popoverProps={{ position: Position.BOTTOM }}
buttonProps={{ minimal: true, rightIcon: 'caret-down' }}
/>
Expand Down