Skip to content

[Game] Load room preview scene correctly #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2023
Merged

[Game] Load room preview scene correctly #2664

merged 1 commit into from
Sep 9, 2023

Conversation

@gok99
Copy link
Contributor

@gok99 gok99 commented Sep 4, 2023

Description

It seems like update now does not wait for create to be invoked. Let's add a quick check before running update

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Check that the example scenes here work.

Checklist

  • I have tested this code
  • I have updated the documentation

@gok99 gok99 requested a review from lhw-1 September 8, 2023 08:34
lhw-1
lhw-1 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gok99, LGTM. Thanks for the PR! I have tested it (while you were beside me) and it seems to work.

@lhw-1 lhw-1 mentioned this pull request Sep 8, 2023
Merged
12 tasks
RichDom2185
RichDom2185 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 4ded31d into source-academy:master Sep 9, 2023
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Sep 10, 2023
@gok99 @RichDom2185
Wait until load for game update (source-academy#2664)
b40138c
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Sep 10, 2023
@gok99 @RichDom2185
Wait until load for game update (source-academy#2664)
b8eb8f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhw-1 lhw-1 lhw-1 approved these changes

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gok99 @lhw-1 @RichDom2185