Skip to content

[Game] Load room preview scene correctly #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2023
Merged

[Game] Load room preview scene correctly #2664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/features/game/scenes/roomPreview/RoomPreview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export default class RoomPreview extends Phaser.Scene {
private verifCont: Phaser.GameObjects.Container | undefined;

private context?: Context;
private sceneLoaded = false;

constructor() {
super('RoomPreview');
Expand Down Expand Up @@ -131,6 +132,7 @@ export default class RoomPreview extends Phaser.Scene {
this.studentCode = SourceAcademyGame.getInstance().getRoomCode();
this.getLayerManager().clearAllLayers();
this.sound.stopAll();
this.sceneLoaded = false;
this.scene.restart();
},
onHover: () => roomRefreshHover.setVisible(true),
Expand All @@ -155,6 +157,7 @@ export default class RoomPreview extends Phaser.Scene {
this.getLayerManager().addToLayer(Layer.UI, roomRefreshHover);

this.getToolbarManager().renderToolbarContainer();
this.sceneLoaded = true;
}

public update() {
Expand All @@ -166,7 +169,9 @@ export default class RoomPreview extends Phaser.Scene {
* Hence, we replace the scope instead of appending
* new one each time.
*/
this.eval(`update();`);
if (this.sceneLoaded) {
this.eval(`update();`);
}
}

public createContext() {
Expand Down