Skip to content

Conversation

@RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Jan 26, 2024

Description

Bumps the major versions of some dependencies, making the necessary migrations and/or fixes to breaking changes as needed.

Supersedes a couple of PRs created by renovate (intentionally done so to more quickly determine which dependencies are safer to update first):

Also adds a new devDependency due to the following warning:

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Everything should still work.

Checklist

  • I have tested this code
  • I have updated the documentation

renovate bot and others added 4 commits January 26, 2024 20:57
Though husky v9 is backwards-compatible with v8, it is still a good
practice to update the formats regardless.
@RichDom2185 RichDom2185 self-assigned this Jan 26, 2024
@coveralls
Copy link

coveralls commented Jan 26, 2024

Pull Request Test Coverage Report for Build 7672304591

  • -3 of 3 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.178%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/adminPanel/subcomponents/NotificationConfigPanel.tsx 0 1 0.0%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx 0 1 0.0%
src/pages/academy/notiPreference/NotiPreference.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 7671782222: 0.0%
Covered Lines: 5722
Relevant Lines: 14452

💛 - Coveralls

renovate bot and others added 12 commits January 27, 2024 01:07
Done due to indentation changes to ternaries in minor version 3.1.
* Rename `cellRendererFramework` to `cellRenderer`
* Rename `suppressCellSelection` to `suppressCellFocus`

Also added some type imports for better type-safety.
Caused by missing transitive
`@babel/plugin-proposal-private-property-in-object` dependency belonging
to CRA, which is not maintained anymore.

Thus, we manually add it as a devDependency here.
This was left out after the migration and thus resulted in a runtime
error previously.
This reverts commit 41457f3.
Copy link
Member Author

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chownces @sayomaki could you help take a look if possible? Don't forget to rerun yarn install after checking out before running CI/lint/tests, thanks!

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, building and testing works fine/as expected, thanks for the changes!

@RichDom2185 RichDom2185 merged commit acafed3 into master Jan 31, 2024
@RichDom2185 RichDom2185 deleted the bump-deps-major branch January 31, 2024 06:23
CYX22222003 pushed a commit to CYX22222003/frontendCYX that referenced this pull request Feb 9, 2024
* Update dependency @testing-library/jest-dom to v6

* Fix testing library breaking changes

* Update dependency husky to v9

* Update husky format for v9

Though husky v9 is backwards-compatible with v8, it is still a good
practice to update the formats regardless.

* Update dependency prettier to v3

* Freeze prettier to 3.0 minor version

Done due to indentation changes to ternaries in minor version 3.1.

* Reformat files post-prettier version upgrade

* Update ag-grid monorepo to v31

* Fix `ag-grid` breaking changes

* Rename `cellRendererFramework` to `cellRenderer`
* Rename `suppressCellSelection` to `suppressCellFocus`

Also added some type imports for better type-safety.

* Fix warning when starting dev server

Caused by missing transitive
`@babel/plugin-proposal-private-property-in-object` dependency belonging
to CRA, which is not maintained anymore.

Thus, we manually add it as a devDependency here.

* Fix `ag-grid` incorrect CSS import paths

This was left out after the migration and thus resulted in a runtime
error previously.

* Fix format

* Revert "Fix format"

This reverts commit 41457f3.

* Fix format

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants