Remove GitHub Assessments feature #2841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove components * Remove pages * Remove routes * Remove snapshots * Remove tests * Miscellaneous changes to other files
Pull Request Test Coverage Report for Build 8279795347Details
💛 - Coveralls |
RichDom2185
commented
Mar 15, 2024
| readonly notifications: Notification[]; | ||
| readonly googleUser?: string; | ||
| readonly githubAssessment?: MissionRepoData; | ||
| readonly githubOctokitObject: { octokit: Octokit | undefined }; |
There was a problem hiding this comment.
I'm leaving this object here just in case the folders team would require it (to minimise conflicts); but if it turns out to not be needed then it can be removed in the future.
Comment on lines
60
to
63
| function* githubLogoutSaga() { | ||
| if (store.getState() && store.getState().workspaces.githubAssessment.hasUnsavedChanges) { | ||
| yield call(showWarningMessage, 'You have unsaved changes!', 2000); | ||
| return; | ||
| } | ||
|
|
||
| yield put(actions.removeGitHubOctokitObjectAndAccessToken()); | ||
| yield call(showSuccessMessage, `Logged out from GitHub`, 1000); | ||
| } |
There was a problem hiding this comment.
Ditto, I'll keep these sagas just in case (leaving them in won't break anything), but we can remove in the future if the folders team do not require them.
Comment on lines
+17
to
+22
| // const conditionalLoader = (condition: boolean, redirectTo: string, returnValue?: any) => () => { | ||
| // if (condition) { | ||
| // return redirect(redirectTo); | ||
| // } | ||
| // return returnValue ?? null; | ||
| // }; |
There was a problem hiding this comment.
Kept for future refactoring purposes.
CYX22222003
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Update .env example file * Update workflows, README * Remove most GitHub Assessments-related files * Remove components * Remove pages * Remove routes * Remove snapshots * Remove tests * Miscellaneous changes to other files * Remove GitHub Assessments CSS module * Remove missed component * Remove GitHub Assessments-related types * Update test snapshots * Fix compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2838.
Type of change
How to test
Checklist