Skip to content

Add XP to Profile #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2018
Merged

Add XP to Profile #318

merged 6 commits into from
Aug 23, 2018

Conversation

@remo5000
Copy link
Contributor

@remo5000 remo5000 commented Aug 22, 2018 •
edited
Loading

Features

  • XP and grade values are 0 by default (less dependence on undefined values)
  • Betcha button is enabled
  • Progress bar is enabled

Issues fixes

@coveralls
Copy link

coveralls commented Aug 22, 2018

Pull Request Test Coverage Report for Build 688

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 26.065%
Totals Coverage Status
Change from base Build 686: -0.02%
Covered Lines: 885
Relevant Lines: 2890
💛 - Coveralls

@remo5000 remo5000 requested review from indocomsoft, ning-y and rrtheonlyone and removed request for ning-y August 23, 2018 01:33
@ning-y
Copy link
Member

ning-y commented Aug 23, 2018

Might want to indicate that betcha is enabled with this PR. Also reminder to bump version and make release notes and deploy.

rrtheonlyone
rrtheonlyone approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@rrtheonlyone rrtheonlyone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

PR adds:

  • 'Betcha' button for extra EXP
  • Progress Bars in profile for grade / EXP

@remo5000 remo5000 merged commit ed14771 into master Aug 23, 2018
remo5000 added a commit that referenced this pull request Aug 24, 2018
@remo5000
Revert "Add XP to Profile (#318)"
ff6f4e0 
This reverts commit ed14771.
@remo5000 remo5000 mentioned this pull request Aug 24, 2018
Merged
1 task
remo5000 added a commit that referenced this pull request Aug 24, 2018
@remo5000
Revert "Add XP to Profile (#318)" (#322)
f158d13 
This reverts commit ed14771.
@remo5000 remo5000 mentioned this pull request Sep 1, 2018
Closed
@rrtheonlyone rrtheonlyone deleted the xp-profile branch September 12, 2018 01:38
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
@dependabot @indocomsoft
Bump quantum from 2.3.3 to 2.3.4 (source-academy#318)
2b908a3 
Bumps [quantum](https://github.com/quantum-elixir/quantum-core) from 2.3.3 to 2.3.4.
- [Release notes](https://github.com/quantum-elixir/quantum-core/releases)
- [Changelog](https://github.com/quantum-elixir/quantum-core/blob/master/CHANGELOG.md)
- [Commits](quantum-elixir/quantum-core@v2.3.3...v2.3.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrtheonlyone rrtheonlyone rrtheonlyone approved these changes

@indocomsoft indocomsoft Awaiting requested review from indocomsoft

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable grade progress bar

5 participants

@remo5000 @coveralls @ning-y @rrtheonlyone