Skip to content

Conversation

@1001mei
Copy link
Contributor

@1001mei 1001mei commented Apr 9, 2024

No description provided.

@1001mei 1001mei marked this pull request as ready for review April 9, 2024 16:47
@github-actions
Copy link

github-actions bot commented Apr 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.9% (-0.12% 🔻)
5946/7834
🟡 Branches
65.81% (+1.37% 🔼)
1965/2986
🟡 Functions
75.35% (-0.2% 🔻)
1012/1343
🟡 Lines
75.64% (-0.73% 🔻)
5687/7519
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / test-utils.ts
96% 0% 100% 96%
🟢 compiler/grammar.ts 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 types/errors.ts
77.78% (-2.22% 🔻)
100%
55.56% (-4.44% 🔻)
77.78% (-2.22% 🔻)
🟢
... / environment.ts
85.94% (-0.65% 🔻)
21.43% (-21.43% 🔻)
92.86% (+6.19% 🔼)
89.66% (-0.34% 🔻)
🟢
... / primitives.ts
79.39% (-0.12% 🔻)
64.1%
84.85% (-0.45% 🔻)
80.58% (-1.51% 🔻)
🟡 types/types/type.ts
45.45% (-21.21% 🔻)
0% (-100% 🔻)
83.33% (+33.33% 🔼)
62.5% (-4.17% 🔻)
🟢
... / binary-writer.ts
79.39% (-0.61% 🔻)
59.09%
61.29% (-2.04% 🔻)
81.9% (-0.71% 🔻)

Test suite run success

1033 tests passing in 50 suites.

Report generated by 🧪jest coverage report action from 2e31f31

@1001mei 1001mei requested a review from Chang-CH April 9, 2024 16:49
Copy link
Contributor

@Chang-CH Chang-CH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, looks good otherwise

@Chang-CH Chang-CH self-requested a review April 10, 2024 04:03
Copy link
Contributor

@Chang-CH Chang-CH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chang-CH Chang-CH merged commit 1b0e7f9 into main Apr 10, 2024
@Chang-CH Chang-CH deleted the compiler branch April 10, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants